Open
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Switch the workflow trigger from push to pull_request and replace the Coveralls upload with orgoro/coverage@v3.2 gating PRs on an 80% threshold for both overall and modified lines. Exclude the legacy SOAP crab.py gateway from coverage — it has no test suite and would skew the metric. Add pytest-cov to the dev extras and regenerate requirements-dev.txt.
vancamti
force-pushed
the
feature/273_test_coverage
branch
from
12dd3bb to
240c6ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend.yamltrigger frompushtopull_requestand add aCode Coverage Reportstep usingorgoro/coverage@v3.2withthresholdAll: 0.8andthresholdModified: 0.8.coverage run+ Coveralls withpytest --cov=crabpy --cov-report=xml.pytest-covto the[dev]extras and regeneraterequirements-dev.txt.crabpy/gateway/crab.pyvia[tool.coverage.run] omit— the legacy SOAP CRAB gateway has no test suite today (25% covered) and would hide the real project coverage. Suggest tracking a follow-up issue to backfill its tests.Coverage with the exclusion sits at 89% locally (125 tests).
Test plan
Code Coverage Reportstep posts a comment.Closes #273